Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue839 #844

Merged
merged 3 commits into from
Jul 28, 2020
Merged

Issue839 #844

merged 3 commits into from
Jul 28, 2020

Conversation

brianhuffman
Copy link
Contributor

Report many more unsolvable class constraints as Unsolvable.

Also make the explanations/error messages a bit more uniform.
Fixes #839.

Add regression test for all implicit instance rules in cryptol.

This includes a set of declarations in a file to test the rules in the context of type checking. It also includes a set of type queries to test the rules (or absence of rules) in the context of type inference.

Brian Huffman added 2 commits July 28, 2020 15:41
Also make the explanations/error messages a bit more uniform.
Fixes #839.
This includes a set of declarations in a file to test the rules
in the context of type checking. It also includes a set of type
queries to test the rules (or absence of rules) in the context
of type inference.
@brianhuffman brianhuffman requested a review from yav July 28, 2020 23:01
@brianhuffman
Copy link
Contributor Author

The instance.icry test should exercise all of the possible error messages for unsolvable constraints from Cryptol/TypeCheck/Solver/Class.hs

@brianhuffman
Copy link
Contributor Author

I should probably extend the test to include the fraction function and the FLiteral class, which I failed to put in there.

@brianhuffman
Copy link
Contributor Author

I'll leave the FLiteral stuff for a later PR.

@brianhuffman brianhuffman merged commit 007e966 into master Jul 28, 2020
@brianhuffman brianhuffman deleted the issue839 branch September 9, 2020 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logic (Float e p) should be unsolvable
2 participants