Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docstring for 'RoundingMode'. Fixes #836. #842

Merged
merged 1 commit into from
Jul 28, 2020
Merged

Add docstring for 'RoundingMode'. Fixes #836. #842

merged 1 commit into from
Jul 28, 2020

Conversation

brianhuffman
Copy link
Contributor

No description provided.

@brianhuffman brianhuffman requested a review from yav July 28, 2020 22:15
yav
yav approved these changes Jul 28, 2020
View reviewed changes
Copy link
Member

@yav yav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. To only thing I'd say that we may want to add the short versions too (e.g., rne, rna, etc), although I am not sure if we should encourage people to use the long or the short names.

@brianhuffman brianhuffman merged commit 1a2456a into master Jul 28, 2020
@brianhuffman
Copy link
Contributor Author

Alternatively, we could mention the short names in the help text for the long-named versions. (And maybe vice versa as well.)

@brianhuffman brianhuffman deleted the issue836 branch September 9, 2020 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yav yav yav approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brianhuffman @yav