Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue835 #841

Merged
merged 2 commits into from
Jul 28, 2020
Merged

Issue835 #841

merged 2 commits into from
Jul 28, 2020

Conversation

brianhuffman
Copy link
Contributor

Place parens appropriately when pretty printing types.

Fixes #835.

@brianhuffman brianhuffman requested a review from yav July 28, 2020 20:59
yav
yav approved these changes Jul 28, 2020
View reviewed changes
Copy link
Member

@yav yav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that look right.

Btw, looking at the pretty printing code for predicates TCon (PC pc) ts, I wonder why we have special cases for a bunch of the classes, it seems to me that the fall trough case would handle all of them. That's a separate issue though

@brianhuffman
Copy link
Contributor Author

Yeah, I noticed that too. In the end I decided to keep the changeset as small as possible for this patch.

@brianhuffman brianhuffman merged commit cf57a0f into master Jul 28, 2020
@brianhuffman brianhuffman deleted the issue835 branch September 9, 2020 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yav yav yav approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect pretty printing for types
2 participants
@brianhuffman @yav