Check the repository owner in CI tasks #1792
Merged
+5
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orks. - don't try to sign things - don't try to push images - don't try to build and push the docs (maybe it should build and not push the docs, but building the docs was already turned off, just not fully)
sauclovian-g
added
bug
sauclovian-g
temporarily deployed
to
github-pages
GitHub Actions
Inactive
RyanGlScott
approved these changes
Jan 30, 2025
This was referenced Jan 30, 2025
kquick
reviewed
Jan 31, 2025
There was a problem hiding this comment.
Is there a reason to check github.event.pull_request.head.repo.fork if we are testing github.repository_owner? Does the latter subsume the former?
It would also be good to add some comments in the yaml file explaining the purpose of using github.repository_owner over a pull_request test (i.e. the scheduled tasks, which do not have a pull request context).
|
That's a good question. I think it won't if we create our own fork within the GH organization (or at least, it would make sense that way) ... it is not completely implausible that we might do that sometime. Re the comments I'll make another changeset... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered recently after updating a fork I'd had sitting around that its periodic CI runs on master were failing.
Apparently it isn't possible to have scheduled runs that are skipped in forks (see https://github.com/orgs/community/discussions/16109 for an open/ignored feature request) but it is at least possible to have them not break.