Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix freeVars calculation for TNominal #1774

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

RyanGlScott
Copy link
Contributor

Rather than computing the free variables of a NominalType definition, we only include the name of the NominalType itself as a free variable.

Fixes #1773.

Rather than computing the free variables of a `NominalType` definition, we only
include the name of the `NominalType` itself as a free variable.

Fixes #1773.
Copy link
Member

@yav yav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RyanGlScott RyanGlScott merged commit 56a93da into master Nov 21, 2024
49 checks passed
@RyanGlScott RyanGlScott deleted the T1773-fix-TNominal-freeVars branch November 21, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect FreeVars Type case for newtypes and enums
2 participants