Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic syntax highlighting for Cryptol in Emacs #1764

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kquick
Copy link
Member

@kquick kquick commented Oct 31, 2024

No description provided.

@RyanGlScott
Copy link
Contributor

It's worth noting that we have been moving towards consolidating all of the syntax-highlighting utilities into centralized repos. For instance, we now have a https://github.com/GaloisInc/galois-vim-syntax repo that contains Vim syntax highlighters for Cryptol, Daedalus, and SAW. I wonder if we should do something similar for Emacs syntax highlighters.

@mccleeary-galois
Copy link
Contributor

It's worth noting that we have been moving towards consolidating all of the syntax-highlighting utilities into centralized repos. For instance, we now have a https://github.com/GaloisInc/galois-vim-syntax repo that contains Vim syntax highlighters for Cryptol, Daedalus, and SAW. I wonder if we should do something similar for Emacs syntax highlighters.

That is a good idea for emacs as well, lets not stop this from going in at the moment though.

@RyanGlScott
Copy link
Contributor

RyanGlScott commented Oct 31, 2024

Certainly, my comment should not be interpreted as a criticism, just that we should be mindful of this in the future if we add more Emacs syntax highlighters. (I could be mistaken, but I believe that this one is the only Emacs one we have so far, so I think it's fine to store this in the cryptol repo for now.)

I'm not an Emacs user, so I don't have any valuable feedback to give on the technical contents of the PR itself.

Copy link
Contributor

@mccleeary-galois mccleeary-galois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with RyanS that we should consider making a emacs syntax highlighting repo. We should also probably update the readme to let folks know what environments we have some minimal support for.

@weaversa
Copy link
Collaborator

Certainly, my comment should not be interpreted as a criticism, just that we should be mindful of this in the future if we add more Emacs syntax highlighters. (I could be mistaken, but I believe that this one is the only Emacs one we have so far, so I think it's fine to store this in the cryptol repo for now.)

I'm not an Emacs user, so I don't have any valuable feedback to give on the technical contents of the PR itself.

There is one here: https://github.com/thoughtpolice/cryptol-mode

@kquick
Copy link
Member Author

kquick commented Oct 31, 2024

I had not known about that existing repo: thank you! From a technical perspective, it is more complete (although a bit out of date for things like the keywords).

I'd propose we pause this MR, remove the vim syntax from this repo, and modify the README to refer to the vim-syntax repo. Meanwhile, I'll propose an update MR to the thoughtpolice repo and if that repo is still supporting updates, we can update the cryptol README to reference it; otherwise I'll fork that one to a Galois emacs-syntax repo and we can reference that one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants