Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cryptol-remote-api to Python 3.12 #1660

Merged
merged 9 commits into from
May 15, 2024
Merged

Update cryptol-remote-api to Python 3.12 #1660

merged 9 commits into from
May 15, 2024

Conversation

mccleeary-galois
Copy link
Contributor

@mccleeary-galois mccleeary-galois commented May 15, 2024 •
edited
Loading

Fix #1653 Fix #1645

This PR also bumps cryptol-remote-api to python 3.12. Added a note in the cryptol-remote-api readme for supported python versions.

Ptival and others added 3 commits May 14, 2024 15:50
@Ptival
fix #1653: distutils.find_executable -> shutil.which
2c31913
@mccleeary-galois
Update python dependencies in cryptol-remote-api
6b3a888 
Unlocking requests, urllib3, types-requests in the toml file to create a new lock file with the intent of being 3.12 compatible.
@mccleeary-galois
Update python version to 3.12 in CI
03ceddf
@RyanGlScott
Copy link
Contributor

Thanks for working on this!

Regarding the mypy error, some things to try:

  • The Python version in the mypy.ini is hardcoded to 3.7 here. We should try bumping that to 3.12. (Also, let's leave comments in all the places we set the Python versions that point to each other. That way, we remember to update them all in one go in the future.)
  • If that fails, it may be worth upgrading the mypy version to see if a newer version is improved. (We are currently locking mypy to 0.991, but the latest version is 1.10.)

@mccleeary-galois
Update mypy to most recent version
d29ac4f 
Also updating mypy to 3.12 and re running poetry lock
@mccleeary-galois mccleeary-galois mentioned this pull request May 15, 2024
Closed
@mccleeary-galois mccleeary-galois mentioned this pull request May 15, 2024
Open
@mccleeary-galois mccleeary-galois changed the title Rem/fix 1653/fix 1645 Update cryptol-remote-api to Python 3.12 May 15, 2024
@mccleeary-galois mccleeary-galois marked this pull request as ready for review May 15, 2024 15:11
mccleeary-galois and others added 3 commits May 15, 2024 10:45
@mccleeary-galois
Bump argo submodule to python3.12
6a69cae
@mccleeary-galois
Add caveat to cryptol-remote-api README regarding shipped containers …
f4b2cf2 
…default python version.
@mccleeary-galois @RyanGlScott
Update cryptol-remote-api/python/README.md
5d3335b 
Additional clarity around python version official support and docker images.

Co-authored-by: Ryan Scott <[email protected]>
@mccleeary-galois mccleeary-galois force-pushed the rem/fix-1653/fix-1645 branch from c88c106 to 5d3335b Compare May 15, 2024 16:46
@mccleeary-galois mccleeary-galois merged commit 079de61 into master May 15, 2024
45 checks passed
@mccleeary-galois mccleeary-galois deleted the rem/fix-1653/fix-1645 branch May 15, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyanGlScott RyanGlScott RyanGlScott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove distutils import from cryptol-remote-api Support latest version of types-requests
3 participants
@mccleeary-galois @RyanGlScott @Ptival