Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow cryptol implementation of foreign functions #1565

Merged
merged 13 commits into from
Aug 22, 2023
Merged

Allow cryptol implementation of foreign functions #1565

merged 13 commits into from
Aug 22, 2023

Conversation

qsctr
Copy link
Contributor

@qsctr qsctr commented Aug 21, 2023

Closes #1397.

@qsctr qsctr added language Changes or extensions to the language FFI Foreign function interface labels Aug 21, 2023
@qsctr qsctr self-assigned this Aug 21, 2023
@qsctr qsctr temporarily deployed to github-pages August 21, 2023 17:49 — with GitHub Actions Inactive
@qsctr
Define foreignLibPath when FFI disabled
7f7ec41 
Fixes build error when FFI is disabled.
@qsctr qsctr temporarily deployed to github-pages August 22, 2023 01:49 — with GitHub Actions Inactive
@qsctr qsctr temporarily deployed to github-pages August 22, 2023 02:26 — with GitHub Actions Inactive
@qsctr qsctr temporarily deployed to github-pages August 22, 2023 02:42 — with GitHub Actions Inactive
@qsctr qsctr temporarily deployed to github-pages August 22, 2023 02:45 — with GitHub Actions Inactive
@qsctr qsctr temporarily deployed to github-pages August 22, 2023 17:54 — with GitHub Actions Inactive
@qsctr qsctr temporarily deployed to github-pages August 22, 2023 20:31 — with GitHub Actions Inactive
@qsctr qsctr temporarily deployed to github-pages August 22, 2023 20:35 — with GitHub Actions Inactive
@qsctr qsctr temporarily deployed to github-pages August 22, 2023 20:41 — with GitHub Actions Inactive
@qsctr qsctr temporarily deployed to github-pages August 22, 2023 20:54 — with GitHub Actions Inactive
@qsctr qsctr temporarily deployed to github-pages August 22, 2023 21:04 — with GitHub Actions Inactive
@qsctr qsctr requested a review from yav August 22, 2023 21:04
@qsctr qsctr marked this pull request as ready for review August 22, 2023 21:04
yav
yav approved these changes Aug 22, 2023
View reviewed changes
Copy link
Member

@yav yav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@qsctr qsctr merged commit fde44e7 into master Aug 22, 2023
@qsctr qsctr deleted the foreign-cryptol-def branch August 22, 2023 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyanGlScott RyanGlScott RyanGlScott left review comments

@yav yav yav approved these changes

Assignees

@qsctr qsctr

Labels
FFI Foreign function interface language Changes or extensions to the language
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cryptol implementation of foreign functions
3 participants
@qsctr @yav @RyanGlScott