Support Integer
, Z
, and Rational
in FFI
#1432
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for
Integer
,Z
, andRational
in the FFI, mapping to GMPmpz_t
andmpq_t
.For
Integer
andZ
arguments are mapped toconst mpz_t
input parameter and return types are mapped tompz_t
output parameter. ForRational
it isconst mpq_t
andmpq_t
respectively. Sequences of these types are supported too, mapping to pointers to those types.Note: Right now
Z
always usesmpz_t
even if the modulus is small enough to fit in anInt
. Also, the type argument ofZ
is allowed to be polymorphic. Not sure if either of those are the right choices.Remaining work:
Closes #1395.