Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Improve signing and tag workflows #1356

Merged
merged 3 commits into from
May 19, 2022
Merged

CI: Improve signing and tag workflows #1356

merged 3 commits into from
May 19, 2022

Conversation

RyanGlScott
Copy link
Contributor

@RyanGlScott RyanGlScott added the CI Continuous integration label May 19, 2022
kquick
kquick reviewed May 19, 2022
View reviewed changes
.github/ci.sh Show resolved Hide resolved
@RyanGlScott
Copy link
Contributor Author

I've confirmed that extracting one of the build artifacts from this PR's workflow page yields both a tarball and a corresponding .sig file, indicating that this works as expected.

@RyanGlScott
CI: Always sign binary artifacts, not just for releases
870d9c9 
Fixes #1355.
@RyanGlScott
CI: Trigger full release after git tag --push
fff6520 
This fixes the regex used to detect tagged releases and runs the
`build-push-image` job for tagged releases.

Fixes #1351.
@RyanGlScott
CI: Use modern GPG keys
e630fbe 
Most of the changes are in GitHub's secret values. The only thing that must
change in the code is the name of the key we search for.

Fixes #1354.
@RyanGlScott RyanGlScott merged commit 34bd329 into master May 19, 2022
@RyanGlScott RyanGlScott deleted the ci-improvements branch May 19, 2022 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kquick kquick kquick left review comments

Assignees
No one assigned
Labels
CI Continuous integration
Projects
None yet
Milestone
No milestone
2 participants
@RyanGlScott @kquick