feat(rpc): check, AES example/test #1159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atomb
approved these changes
Apr 9, 2021
| @@ -126,6 +125,54 @@ def __init__(self, connection : HasProtocolState, fun : str, args : List[Any]) - | |||
| def process_result(self, res : Any) -> Any: | |||
| return from_cryptol_arg(res['value']) | |||
|
|
|||
|
|
|||
| @dataclass | |||
| class CheckReport: | |||
There was a problem hiding this comment.
I wonder whether it would be useful to include the values leading to failure in the case where check fails, in a form compatible with prove. In some sense, check and prove should be usable somewhat interchangeably, so making them compatible when possible seems useful.
There was a problem hiding this comment.
Oh, never mind. It does. That's what args is. I guess the one additional possibility is to include names for those arguments, like I recently added to prove (and I think maybe should be added to prove and sat on the Cryptol side). But that could be in a separate PR later, I think.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Essentially adds
:checkto the Python interface.Partially addresses remaining issues here: GaloisInc/argo#121
Adds an additional simple test for the Python interface (i.e.,
test_AES.py).