Float check #1069
Merged
Float check #1069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by enumerating all bitpatterns. Note, this overcounts somewhat the number of distinct floating point values there are, since all NaNs are considered identical as `Float` values. We could be more careful here to avoid generating more NaN values than required, but I'm not sure it's worth the effort. Fixes #1051
This generator will will generate "special" values, and should also provide better coverage across the range of values the type can represent, instead of being strongly biased toward values near 1, as the old generator was.
brianhuffman
approved these changes
Feb 10, 2021
There was a problem hiding this comment.
I agree that having :exhaust test multiple NaN values is not a problem: If the float type is small enough to be exhaustively tested, then you're going to be spending a relatively small amount of time checking NaN cases anyway.
For the random test generation, there seems to be a lot of arbitrary choices in there, and I'm wondering whether simply using genBinary by itself would suffice (with a small modification to replace NaN values with infinities half the time). In any case, the extra heuristics shouldn't hurt, so it probably doesn't matter much.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement
:exhaustfor floating point values, and improve the random generator to produce more representative samples.