Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing parens in pretty printer for types #933

Closed
brianhuffman opened this issue Oct 15, 2020 · 0 comments · Fixed by #966
Closed

Missing parens in pretty printer for types #933

brianhuffman opened this issue Oct 15, 2020 · 0 comments · Fixed by #966
Assignees
@brianhuffman
Labels
bug Something not working correctly UX Issues related to the user experience (e.g., improved error messages)
Milestone
2.10.0

Comments

@brianhuffman
Copy link
Contributor

Apparently we got the precedences wrong in the pretty printer for Cryptol types:

Cryptol> :t [zero : Z 5]
[zero : Z 5] : [1]Z 5

This should be [1](Z 5) instead of [1]Z 5, because [1]Z 5 doesn't parse:

Cryptol> [zero] : [1]Z 5

Parse error at <interactive>:1:15,
  unexpected: 5
@robdockins robdockins added bug Something not working correctly UX Issues related to the user experience (e.g., improved error messages) labels Oct 27, 2020
@brianhuffman brianhuffman self-assigned this Nov 13, 2020
@atomb atomb added this to the 2.10.0 milestone Nov 13, 2020
brianhuffman pushed a commit that referenced this issue Nov 13, 2020
Fix parens in pretty printing of sequence types.
ade7a53 
The fix required inserting another precedence level for sequence types
`[n]a` (level 4) in between `app_type` (level 3) and `atype` (now
level 5).

Fixes #933.
brianhuffman pushed a commit that referenced this issue Nov 13, 2020
Add regression test for #933.
d3b83b3
@brianhuffman brianhuffman mentioned this issue Nov 13, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brianhuffman brianhuffman

Labels
bug Something not working correctly UX Issues related to the user experience (e.g., improved error messages)
Projects
None yet
Milestone
2.10.0
Development

Successfully merging a pull request may close this issue.

Fix parens in pretty printing of sequence types. GaloisInc/cryptol
3 participants
@atomb @brianhuffman @robdockins