Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable Docker test for ABC #919

Closed
atomb opened this issue Sep 30, 2020 · 2 comments
Closed

Re-enable Docker test for ABC #919

atomb opened this issue Sep 30, 2020 · 2 comments
Assignees
@atomb
Labels
build system Related to Cryptol's build system

Comments

@atomb
Copy link
Contributor

atomb commented Sep 30, 2020

Commit 809fd34 temporarily disables testing ABC during Docker builds, due to #915, so that we can still get builds while we diagnose this problem (which is only a fatal problem for some use cases). But I don't want to forget to re-enable it as soon as we close #915.
@atomb atomb added this to the 2.10.0 milestone Sep 30, 2020
@atomb atomb self-assigned this Sep 30, 2020
@robdockins robdockins added the build system Related to Cryptol's build system label Sep 30, 2020
@atomb atomb removed this from the 2.10.0 milestone Nov 18, 2020
@atomb
Copy link
Contributor Author

atomb commented Nov 18, 2020

The following abc issue describes the root of the problem, and an interim fix if you build it yourself: berkeley-abc/abc#107

atomb pushed a commit that referenced this issue Dec 1, 2020
Re-enable testing ABC in Docker, now that it works
0db9e7d 
Closes #919.
@atomb
Copy link
Contributor Author

atomb commented Dec 1, 2020

Apparently "Closes" is not one of the keywords GitHub uses to automatically close issues...

@atomb atomb closed this as completed Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atomb atomb

Labels
build system Related to Cryptol's build system
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@atomb @robdockins