Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix printing of type constraints in :browse #731

Closed
yav opened this issue May 18, 2020 · 0 comments · Fixed by #733
Closed

Fix printing of type constraints in :browse #731

yav opened this issue May 18, 2020 · 0 comments · Fixed by #733

Comments

@yav
Copy link
Member

yav commented May 18, 2020

Declaration in module:

type T n = (fin n, n >= 1)

If we type :browse we get this:

type constraint T n = (&&) fin n (n >= 1)

Note that there are two bugs here: fin is not parenthesized, and we see && instead of the tuple form.
@brianhuffman brianhuffman changed the title Fix printing of type constrazints in :browse Fix printing of type constraints in :browse May 18, 2020
brianhuffman pushed a commit that referenced this issue May 19, 2020
Pretty-print Prop constructor PAnd using tuple-style syntax.
e1fb6e9 
This matches the syntax used for parsing type constraint synonyms.

Fixes #731.
brianhuffman pushed a commit that referenced this issue May 19, 2020
Add regression test for #731.
37f1fd8
@brianhuffman brianhuffman mentioned this issue May 19, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue731 GaloisInc/cryptol
1 participant
@yav