Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dumptests with (0 : Integer) panics #615

Closed
yav opened this issue Jun 21, 2019 · 0 comments · Fixed by #642
Closed

dumptests with (0 : Integer) panics #615

yav opened this issue Jun 21, 2019 · 0 comments · Fixed by #642
Assignees
@brianhuffman
Labels
bug Something not working correctly
Milestone
2.8.0

Comments

@yav
Copy link
Member

yav commented Jun 21, 2019 

Cryptol> :dumptests test 0
Showing a specific instance of polymorphic result:
  * Using 'Integer' for the type of '<expr>::(expression)'
cryptol: You have encountered a bug in Cryptol's implementation.
*** Please create an issue at https://github.com/GaloisInc/cryptol/issues

%< --------------------------------------------------- 
  Revision:  4db158eafb7580449f3830aa63998920dd87fe35
  Branch:    master (uncommited files present)
  Location:  Cryptol.Testing.Random
  Message:   Unsupported return value for testing
CallStack (from HasCallStack):
  panic, called at src/Cryptol/Utils/Panic.hs:21:9 in cryptol-2.7.1-inplace:Cryptol.Utils.Panic
  panic, called at src/Cryptol/Testing/Random.hs:72:15 in cryptol-2.7.1-inplace:Cryptol.Testing.Random
%< ---------------------------------------------------
@brianhuffman brianhuffman added the bug Something not working correctly label Jun 24, 2019
@atomb atomb added this to the 2.8.0 milestone Aug 1, 2019
@brianhuffman brianhuffman self-assigned this Aug 29, 2019
brianhuffman pushed a commit that referenced this issue Aug 29, 2019
Make :dumptests check whether type is testable before starting.
64423cb 
Instead of panicking, :dumptests will now print the message
"The expression is not of a testable type" when used with an
inappropriately-typed expression. Also, Integer return values
are now supported.

Fixes #615.
@brianhuffman brianhuffman mentioned this issue Aug 29, 2019
Merged
@brianhuffman brianhuffman mentioned this issue Nov 2, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brianhuffman brianhuffman

Labels
bug Something not working correctly
Projects
None yet
Milestone
2.8.0
Development

Successfully merging a pull request may close this issue.

Make :dumptests check whether type is testable before starting. GaloisInc/cryptol
3 participants
@yav @atomb @brianhuffman