Skip to content

Commit

Permalink
Improve CI for Windows and portable Docker container (#1248)
Browse files Browse the repository at this point in the history
* Disable Windows RPC tests

They seem to hang instead of failing at the moment, so until we get them
working it seems like it's better to just leave them out.

* Attempt to make "portability" build only run nightly.
  • Loading branch information
Aaron Tomb authored Jul 26, 2021
1 parent 8e7e047 commit 5c3cdff
Showing 1 changed file with 12 additions and 13 deletions.
25 changes: 12 additions & 13 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -196,15 +196,13 @@ jobs:
path: bin
name: ${{ runner.os }}-bin

# This is commented out because it appears to fail uploading
# and the entire build fails. XXX: investigate why.
# - uses: actions/upload-artifact@v2
# if: runner.os == 'Windows'
# with:
# name: ${{ env.NAME }}
# path: "cryptol.msi*"
# if-no-files-found: error
# retention-days: ${{ needs.config.outputs.retention-days }}
- uses: actions/upload-artifact@v2
if: runner.os == 'Windows'
with:
name: ${{ env.NAME }}
path: "cryptol.msi*"
if-no-files-found: error
retention-days: ${{ needs.config.outputs.retention-days }}

test:
runs-on: ${{ matrix.os }}
Expand Down Expand Up @@ -296,10 +294,11 @@ jobs:
file: Dockerfile
image: ghcr.io/galoisinc/cryptol
cache: ghcr.io/galoisinc/cache-cryptol
# - build-args: PORTABILITY=true
# file: cryptol-remote-api/Dockerfile
# image: ghcr.io/galoisinc/cryptol-remote-api
# cache: ghcr.io/galoisinc/cache-cryptol-remote-api
- build-args: PORTABILITY=true
file: cryptol-remote-api/Dockerfile
image: ghcr.io/galoisinc/cryptol-remote-api
cache: ghcr.io/galoisinc/cache-cryptol-remote-api
if: ${{ github.event_name == 'schedule' }}
- build-args: PORTABILITY=false
file: cryptol-remote-api/Dockerfile
image: ghcr.io/galoisinc/cryptol-remote-api
Expand Down

0 comments on commit 5c3cdff

Please sign in to comment.