Compositional crux-mir support #659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atomb
approved these changes
Mar 11, 2021
|
|
||
|
|
||
| -------------------------------------------------------------------------------- | ||
| -- ** MethodSpec and MethodSpecBuilder |
There was a problem hiding this comment.
My hope is that someday we can eventually, generalize the stuff from here down, move it to the crux package, and use it for other languages, too.
spernsteiner
force-pushed
the
sp/crux-mir-comp
branch
from
245bbb4 to
f8a12a4
Compare
spernsteiner
force-pushed
the
sp/crux-mir-comp
branch
from
f8a12a4 to
c6b5472
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the crucible/crux-mir component of GaloisInc/saw-script#1117. This branch adds various infrastructure needed to support the main compositional crux-mir implementation in the saw-script repo.
Specifically, this branch adds new Crucible intrinsic types
MethodSpecandMethodSpecBuilder, and adds functions for manipulating them to thecrucibleRust library. However, the intrinsics are defined as existential types, using typeclasses to provide the operations for each type, and no implementations of those typeclasses or overrides for the Rust API functions are included incrux-mir. Instead,saw-script/crux-mir-compdefines concrete implementation types and extendscrux-mirwith the necessary overrides, so that these implementations can usesaw-script'sMethodSpecand related SAW types.This branch also adds some additional functions for manipulating
MirReferences, which are used incrux-mir-comp's handling of memory.