crucible-jvm: Migrate never-updated fields from CodebaseState to Codebase #622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…base `Lang.JVM.Codebase` has a `CodebaseState` data type that is used within an `IORef` in `Codebase`. However, only two of the four fields of `CodebaseState` are ever updated with `writeIORef`, so it doesn't make much sense to keep the other two fields in an `IORef`. This patch moves them from `CodebaseState` to `Codebase` to make this more obvious. This is purely a refactoring and has no user-visible changes in behavior.
|
This was superseded by #638. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lang.JVM.Codebasehas aCodebaseStatedata type that is used within anIORefinCodebase. However, only two of the four fields ofCodebaseStateare ever updated withwriteIORef, so it doesn't make much sense to keep the other two fields in anIORef. This patch moves them fromCodebaseStatetoCodebaseto make this more obvious.This is purely a refactoring and has no user-visible changes in behavior.