Tweaks to bvdomain and strlen #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous value was causing problems with abstract domain calculations and path sat checking.
This almost always results in better code for symbolic execution.
tests the simulator's ability to terminate in a reasonable way in a loop that is upper bounded by the result of `strlen`. This relies on the bitvector abstract domains behaving well enough to determine that certain memory accesses out of bounds.
This tests that the standard Euclidean GCD algorithm symbolically terminates in at most 13 steps for 8-bit values. Without path-sat checking, this will still terminate because of bitvector abstract domain information, but will require many more iterations.
Closed
Thanks to @kquick for this solution.
Apparently, the default differs across platforms, so we fix it here under the assumption that the original compilation to .ll fixed the desired optimization level.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.