Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crux-mir Docker image entrypoint #1277

Merged
merged 1 commit into from
Jan 23, 2025
Merged

Fix crux-mir Docker image entrypoint #1277

merged 1 commit into from
Jan 23, 2025

Conversation

RyanGlScott
Copy link
Contributor

This fixes an oversight introduced in #1265 where the location of cargo was moved to /home/crux-mir/.cargo/bin/cargo in the crux-mir Docker image, but the image entrypoint was not updated accordingly.

Fixes #1276.

@RyanGlScott
Fix crux-mir Docker image entrypoint
1258871 
This fixes an oversight introduced in #1265 where the location of `cargo` was
moved to `/home/crux-mir/.cargo/bin/cargo` in the `crux-mir` Docker image, but
the image entrypoint was not updated accordingly.

Fixes #1276.
@RyanGlScott RyanGlScott self-assigned this Jan 23, 2025
@RyanGlScott RyanGlScott mentioned this pull request Jan 23, 2025
Closed
kquick
kquick approved these changes Jan 23, 2025
View reviewed changes
Copy link
Member

@kquick kquick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At some point it might be nice to add a test that the docker entrypoint works for some minimal input. #1278

@RyanGlScott RyanGlScott merged commit ada93e9 into master Jan 23, 2025
32 checks passed
@RyanGlScott RyanGlScott deleted the T1276-fix-crux-mir-Docker-entrypoint branch January 23, 2025 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kquick kquick kquick approved these changes

@sauclovian-g sauclovian-g Awaiting requested review from sauclovian-g

@mccleeary-galois mccleeary-galois Awaiting requested review from mccleeary-galois

Assignees

@RyanGlScott RyanGlScott

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

crux-mir image won't run
2 participants
@RyanGlScott @kquick