Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IT instruction/conditional blocks #54

Merged
merged 4 commits into from
Nov 7, 2023
Merged

Fix IT instruction/conditional blocks #54

merged 4 commits into from
Nov 7, 2023

Conversation

danmatichuk
Copy link
Collaborator

Fixes support for conditional blocks (via the it instruction) by incrementing the IT register when the instruction encoding asks for it.

Copy link
Contributor

@RyanGlScott RyanGlScott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't fully understand the details of how the it interacts with ShouldAdvanceIT/ITAdvance(), but this approach looks reasonable upon a quick glance.

@danmatichuk danmatichuk merged commit dacd522 into master Nov 7, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants