Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch from ansi-wl-pprint to prettyprinter package. #28

Merged
merged 2 commits into from
Dec 2, 2020
Merged

Switch from ansi-wl-pprint to prettyprinter package. #28

merged 2 commits into from
Dec 2, 2020

Conversation

brianhuffman
Copy link
Contributor

This patch includes and adapts to the following submodule PRs:

Switch from ansi-wl-pprint to prettyprinter package.
4c834b5 
This patch includes and adapts to the following submodule PRs:
- GaloisInc/what4#77 "prettyprinter"
- GaloisInc/crucible#586 "prettyprinter"
@brianhuffman brianhuffman requested a review from travitch December 2, 2020 00:50
@brianhuffman
Copy link
Contributor Author

brianhuffman commented Dec 2, 2020 •
edited
Loading

It looks like the CI builds are failing for an unrelated reason:

  Error: Unable to process command '::add-path::/opt/ghc/8.6.5/bin' successfully.
  Error: The `add-path` command is disabled. Please upgrade to using Environment Files or opt into unsecure command execution by setting the `ACTIONS_ALLOW_UNSECURE_COMMANDS` environment variable to `true`. For more information see: https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/

@brianhuffman brianhuffman mentioned this pull request Dec 2, 2020
Merged
brianhuffman pushed a commit to GaloisInc/macaw that referenced this pull request Dec 2, 2020
Switch from ansi-wl-pprint to the prettyprinter package.
26c6ec5 
This patch relies on the following submodule updates:
- GaloisInc/what4#77
- GaloisInc/elf-edit#20
- GaloisInc/crucible#586
- GaloisInc/asl-translator#28

This patch updates the following packages:
- macaw-base
- macaw-symbolic
- macaw-x86
- macaw-x86-symbolic
- macaw-aarch32
- macaw-ppc
- macaw-semmc
- macaw-refinement
brianhuffman pushed a commit to GaloisInc/macaw that referenced this pull request Dec 2, 2020
Switch from ansi-wl-pprint to the prettyprinter package.
96ad481 
This patch relies on the following submodule updates:
- GaloisInc/what4#77
- GaloisInc/elf-edit#20
- GaloisInc/crucible#586
- GaloisInc/asl-translator#28

This patch updates the following packages:
- macaw-base
- macaw-symbolic
- macaw-x86
- macaw-x86-symbolic
- macaw-aarch32
- macaw-ppc
- macaw-semmc
- macaw-refinement
brianhuffman pushed a commit to GaloisInc/macaw that referenced this pull request Dec 2, 2020
Switch from ansi-wl-pprint to the prettyprinter package.
b9cf8aa 
This patch relies on the following submodule updates:
- GaloisInc/what4#77
- GaloisInc/elf-edit#20
- GaloisInc/crucible#586
- GaloisInc/asl-translator#28

This patch updates the following packages:
- macaw-base
- macaw-symbolic
- macaw-x86
- macaw-x86-symbolic
- macaw-aarch32
- macaw-ppc
- macaw-semmc
- macaw-refinement
@joehendrix
Copy link

Maybe @jared-w is the right person to weigh in on actions/setup-haskell. I'd guess this would be a simple fix to update that action, but don't have a experience with it.

brianhuffman pushed a commit to GaloisInc/macaw that referenced this pull request Dec 2, 2020
Switch from ansi-wl-pprint to the prettyprinter package.
f73730e 
This patch relies on the following submodule updates:
- GaloisInc/what4#77
- GaloisInc/elf-edit#20
- GaloisInc/crucible#586
- GaloisInc/asl-translator#28

This patch updates the following packages:
- macaw-base
- macaw-symbolic
- macaw-x86
- macaw-x86-symbolic
- macaw-aarch32
- macaw-ppc
- macaw-semmc
- macaw-refinement
@brianhuffman
Copy link
Contributor Author

GaloisInc/macaw#178 depends on this PR to pass CI, so I'd like to get this one merged before merging that one.

@hazelweakly
Copy link
Contributor

Long story short, the README for setup-haskell used the v1.1 tag as that tag is the one that introduced some new features like the outputs. I had expected it to be updated along with the v1 tag, but it never was. So the README should've used the v1 tag in its examples.

travitch
travitch approved these changes Dec 2, 2020
View reviewed changes
Copy link
Contributor

@travitch travitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - thanks!

@brianhuffman
Copy link
Contributor Author

Thanks for the fix, @jared-w!

@brianhuffman brianhuffman merged commit 943cf7d into master Dec 2, 2020
brianhuffman pushed a commit to GaloisInc/macaw that referenced this pull request Dec 2, 2020
Switch from ansi-wl-pprint to the prettyprinter package.
2a620d4 
This patch relies on the following submodule updates:
- GaloisInc/what4#77
- GaloisInc/elf-edit#20
- GaloisInc/crucible#586
- GaloisInc/asl-translator#28

This patch updates the following packages:
- macaw-base
- macaw-symbolic
- macaw-x86
- macaw-x86-symbolic
- macaw-aarch32
- macaw-ppc
- macaw-semmc
- macaw-refinement
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@travitch travitch travitch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@brianhuffman @joehendrix @hazelweakly @travitch