Add hostname option #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
This looks good to me.
@atomb, do you think this should go onto the designated branch, or into master? I don't have a lot of insight into how you're working through the server code transition, or what would be most convenient there.
hazelweakly
force-pushed
the
add-hostname
branch
from
8d73e27 to
5f809b5
Compare
kquick
reviewed
Oct 12, 2020
hazelweakly
changed the base branch from
at-move-cryptol-remote-api
to
master
hazelweakly
force-pushed
the
add-hostname
branch
from
5f809b5 to
8c78e13
Compare
|
I updated it to target master instead. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the PR into this branch because that's what saw-script is currently pulling in as a submodule.