Skip to content

Commit

Permalink
Python: Avoid typed-ast dependency
Browse files Browse the repository at this point in the history
The `typed-ast` package is being end-of-life'd soon. See python/typed_ast#179.
Moreover, it is causing issues when building with Python 3.11+. See
GaloisInc/cryptol#1491.  Thankfully, `typed-ast` is no longer required if you
use sufficiently new versions of `mypy` and Python. This patch raises the lower
version bounds to make it possible to shed the `typed-ast` dependency entirely.
  • Loading branch information
RyanGlScott committed Jan 26, 2023
1 parent 2f19ac6 commit d00a3a0
Show file tree
Hide file tree
Showing 3 changed files with 46 additions and 113 deletions.
6 changes: 4 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
steps:
- uses: actions/setup-python@v2
with:
python-version: '3.7'
python-version: '3.11'
- uses: abatilo/[email protected]
with:
poetry-version: 1.1.11
Expand Down Expand Up @@ -51,7 +51,9 @@ jobs:
poetry install
- name: Typecheck python code
working-directory: ./python
run: poetry run mypy argo_client
run: |
poetry run mypy --install-types --non-interactive
poetry run mypy argo_client
- name: Build
run: |
cabal build all
Expand Down
149 changes: 40 additions & 109 deletions python/poetry.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions python/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,12 @@ include = [
"Bug Tracker" = "https://github.com/GaloisInc/argo/issues"

[tool.poetry.dependencies]
python = ">=3.7.0,<4"
python = ">=3.8.0,<4"
requests = "^2.26.0"
urllib3 = ">=1.26.5"

[tool.poetry.dev-dependencies]
mypy = "^0.812"
mypy = "^0.991"

[build-system]
requires = ["poetry>=1.1.4", "setuptools>=40.8.0"]

0 comments on commit d00a3a0

Please sign in to comment.