Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pure Haskell AIGER and CNF generation #8

Merged
merged 10 commits into from
Jun 14, 2021
Merged

Add pure Haskell AIGER and CNF generation #8

merged 10 commits into from
Jun 14, 2021

Conversation

atomb
Copy link

@atomb atomb commented May 24, 2021

This PR adds an instance of the IsAIG class that provides pure Haskell support for reading and writing AIGER files and writing CNF files. It's not very highly optimized yet, but somewhat surprisingly already has pretty decent performance. This allows us to preserve all of SAW's current features while ditching abcBridge. SAW PR GaloisInc/saw-script#1320 depends on this.

@atomb atomb requested a review from robdockins June 4, 2021 20:46
Copy link
Contributor

@robdockins robdockins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good, I think, just a few comments and suggestions.

src/Data/AIG/CompactGraph.hs Show resolved Hide resolved
src/Data/AIG/CompactGraph.hs Show resolved Hide resolved
src/Data/AIG/CompactGraph.hs Outdated Show resolved Hide resolved
src/Data/AIG/CompactGraph.hs Outdated Show resolved Hide resolved
@atomb atomb requested a review from robdockins June 11, 2021 21:56
@robdockins
Copy link
Contributor

I don't see the comments you added. Did you miss pushing a patch here?

@atomb
Copy link
Author

atomb commented Jun 14, 2021

Oh, that's weird. I swear I wrote them, but they're not in the history or in my working copy. I'll add them again!

@atomb atomb merged commit 8398a08 into master Jun 14, 2021
@atomb atomb deleted the at-aiger branch June 14, 2021 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants