-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pure Haskell AIGER and CNF generation #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently uses the ASCII format, for debugging. Will move to binary format once the core functionality is solid.
Also add tests that reading and writing agree.
robdockins
suggested changes
Jun 11, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks good, I think, just a few comments and suggestions.
I don't see the comments you added. Did you miss pushing a patch here? |
Oh, that's weird. I swear I wrote them, but they're not in the history or in my working copy. I'll add them again! |
robdockins
approved these changes
Jun 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an instance of the
IsAIG
class that provides pure Haskell support for reading and writing AIGER files and writing CNF files. It's not very highly optimized yet, but somewhat surprisingly already has pretty decent performance. This allows us to preserve all of SAW's current features while ditchingabcBridge
. SAW PR GaloisInc/saw-script#1320 depends on this.