Allow building with GHC 9.10 #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All that is required is lifting the upper version bounds on `base`.
kquick
approved these changes
Sep 17, 2024
There was a problem hiding this comment.
We have no repo-specific CI to update for this. so this should be all that is needed.
We could add CI to this repo, but I would recommend we could defer that until such time (if any) that this repo is under significant development activity where individual build status is valuable. It is currently built as part of What4's CI, which should be sufficient for now.
It's more likely that we would need to add tests for changes in the underlying ABC library, but that would also involve tracking ABC (which doesn't have releases) and triggering builds on ABC changes (I don't believe github supports cross-repo CI actions).
|
I've opened #19 to track adding CI to this repo. |
RyanGlScott
added a commit
to GaloisInc/what4
that referenced
this pull request
Sep 19, 2024
Bump the upper version bounds on `base` in the various `what4` packages, and bump the `aig` submodule to bring in the changes from GaloisInc/aig#18.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All that is required is lifting the upper version bounds on
base.