Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise an error when trying to run MPS tests without QUICK=1 #69

Merged
merged 2 commits into from
Jun 17, 2024
Merged

Raise an error when trying to run MPS tests without QUICK=1 #69

merged 2 commits into from
Jun 17, 2024

Conversation

podhrmic
Copy link
Collaborator

Fixes #56

@podhrmic podhrmic requested a review from spernsteiner June 17, 2024 18:24
@podhrmic podhrmic self-assigned this Jun 17, 2024
spernsteiner
spernsteiner approved these changes Jun 17, 2024
View reviewed changes
Copy link
Contributor

@spernsteiner spernsteiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this works.

Did you consider the alternative of removing the bad test cases, with a comment saying they should be reinstated once the issue is fixed?

@podhrmic
Copy link
Collaborator Author

I guess this works.

Did you consider the alternative of removing the bad test cases, with a comment saying they should be reinstated once the issue is fixed?

I did - but there are 49 scenarios, so adding this warning was much easier. Given the additional assurance we have from SAW/Cryptol proofs, I would be happy with just a warning.

@podhrmic podhrmic merged commit 8a54ae6 into main Jun 17, 2024
5 checks passed
@podhrmic podhrmic deleted the 56-fix-mps-test-fail branch June 17, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spernsteiner spernsteiner spernsteiner approved these changes

Assignees

@podhrmic podhrmic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] MPS tests fail when running the full suite
2 participants
@podhrmic @spernsteiner