Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bulk addition memory safety #66

Merged
merged 28 commits into from
Nov 8, 2021
Merged

Bulk addition memory safety #66

merged 28 commits into from
Nov 8, 2021

Conversation

nano-o
Copy link
Contributor

@nano-o nano-o commented Oct 5, 2021

No description provided.

Giuliano Losa added 24 commits August 13, 2021 09:43
add blst_bulk_addition submodule
ea81bac
mount blst_bulk_addition
757fb5f
build blst_bulk_addition
9672214
fix docker-compose.yml
77ab8df
add bulk_addition_memory_safety
7b00d44
first attempt at POINTonE1s_accumulate mem safety
df66c7e 
the spec is not as precise as it should: the inputs should be points
whose 3rd element may be uninitialized.
make some progress
bad7c38
another problem...
9b72f76
two cases of memory safety
af6725b
fix call parameter
08817ca
add E2 cases
8919c48
set do_prove to true
47e25f6
note that the interesting cases remain TODO
812c4af
add overrides for internal functions
0d9b6ed 
still needs to update accumulate override to take into account that the
input array has uninitialized holes everywhere
add mem safety for n=16 on E1
a22d9ac
add mem proof for n=17
710d614
add mem safety for n=3
3d7f264
use spec generated by python script
484a6a7
add mem safety proofs for more sizes (still E1)
5bef4a3 
also add patch to set stride to 32
add second spec
2dea585
remove overrides for accumulate
785e033
add E2 proofs
b50fd2f
fix build_x86
670fa00
add exp2_for_bulk_add.saw
033de44
@nano-o nano-o marked this pull request as ready for review October 5, 2021 18:22
@nano-o nano-o requested a review from bboston7 October 5, 2021 18:22
bboston7
bboston7 approved these changes Oct 5, 2021
View reviewed changes
Copy link
Contributor

@bboston7 bboston7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@andreistefanescu andreistefanescu merged commit f7a730d into main Nov 8, 2021
@KarmaHaze KarmaHaze linked an issue Mar 27, 2023 that may be closed by this pull request
#74 #76
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bboston7 bboston7 bboston7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

#74
3 participants
@nano-o @bboston7 @andreistefanescu