Support opening of new terminal windows in WSL #1503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Detect if pwntools is running in a Windows Subsystem for Linux "VM" and set the terminal to open a new `cmd.exe` window on the host. This replaces the need to add `context.terminal = ['cmd.exe', '/c', 'start', 'ubuntu', 'run']` to every script. Debugging using `gdb.attach` under WSL with gdb in a new window out of the box!
|
This is great, thanks! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detect if pwntools is running in a Windows Subsystem for Linux "VM" and set the terminal to open a new
cmd.exewindow on the host.This replaces the need to add
context.terminal = ['cmd.exe', '/c', 'start', 'ubuntu', 'run']to every script. Instead of hardcoding a distribution likeubuntuuse the selected default distribution in WSL. Runningwsl.exeinstead ofbash.execaused the new window to close immediately, so I've settled withbash.exe. If someone has a differentbash.exein their path before the WSL binaries - well they'll need to fix their environment.https://devblogs.microsoft.com/commandline/a-guide-to-invoking-wsl/
Debugging using
gdb.attachunder WSL with gdb in a new window out of the box! Since this is added as the last option in the list of possible terminals, running screen or tmux in wsl will still use those.