Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GafferCycles : Custom AOV fix + unit test #5044

Merged
merged 3 commits into from
Jan 4, 2023

Conversation

boberfly
Copy link
Collaborator

https://groups.google.com/g/gaffer-dev/c/m8NXKI9NIVE

Generally describe what this PR will do, and why it is needed

  • Fix for incorrectly passing the wrong pass name enum when constructing a custom AOV CyclesOutput, which caused custom AOVs to never be rendered unless they were named aov_color or aov_value
  • Unit test added for custom AOVs

Related issues

Dependencies

Breaking changes

Checklist

  • I have read the contribution guidelines.
  • I have updated the documentation, if applicable.
  • I have tested my change(s) in the test suite, and added new test cases where necessary.
  • My code follows the Gaffer project's prevailing coding style and conventions.

@boberfly boberfly changed the base branch from main to 1.1_maintenance December 21, 2022 12:30
Copy link
Member

@johnhaddon johnhaddon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Alex, it's great to see the test coverage continue to ramp up like this! I've made a comment inline about standardising on float/color syntax, which - unless I missed something - I think is probably worth doing while we're still reserving the right to break things to improve things in GafferCycles.

@boberfly boberfly force-pushed the fix/cyclesCustomAOV branch from 831445e to 7611214 Compare January 4, 2023 01:36
@johnhaddon johnhaddon merged commit b6cb13f into GafferHQ:1.1_maintenance Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants