Allow EditScopes to Contain Created Lights #6172
Comments
johnhaddon
added a commit
to johnhaddon/gaffer
that referenced
this issue
Dec 10, 2024
We were already allowing edits in a nominated EditScope even when there was a downstream override that would prevent you from seeing the result. This was communicated in the UI by an orange "overridden" background colour in the inspector cell, and a warning message in the editing popup window. But in "Source" mode we made no such allowance, meaning that you couldn't make an edit at source if it was overridden downstream, and the UI didn't even show you that it was overridden downstream. There was no background colour and a spurious message about the target not being in the history. We now treat "Source" mode the same as EditScope mode, allowing edits at source even when overridden downstream. Along with that the UI now also shows the overridden status in the background colour and shows the appropriate warning when editing. This commit bundles a couple of other things which might ideally have been separate commits, but which arose naturally while figuring out the implementation : - Consolidated some member data into a single `Result::m_editors` struct. This encourages everything to be initialised together, making the data flow a little clearer, and using `std::optional` to make it unambiguous whether we have initialised yet or not. - Adjusted the failure messages when an attempt is made to disabled a non-existent edit. Instead of directing the user to change edit scope and disabled a _different_ edit, we now just explain that there is no edit to disable. Fixes GafferHQ#6172.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Version: 1.5.1.0
Description
When using edit scopes. If the edit scope contains lights within itself it disallows you the ability to alter the settings of that edit scope when focusing on a later scope.
Steps to reproduce
The text was updated successfully, but these errors were encountered: