Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mesh Light Visualisation Failure Case #6002

Closed
LinasBeres opened this issue Aug 13, 2024 · 0 comments · Fixed by #6066
Closed

Mesh Light Visualisation Failure Case #6002

LinasBeres opened this issue Aug 13, 2024 · 0 comments · Fixed by #6066
Assignees
@johnhaddon

Comments

@LinasBeres
Copy link

Version: Gaffer 1.3.16.7-linux
Third-party tools: Arnold
Third-party modules: proprietary plugins

Description

At IE we have mesh light visualisations that were working in 1.2, but have since stopped in 1.3+. Not quite sure whether to put this as a bug or a feature, but for now it's a bug since it's a feature that existed but now doesn't.

The implementations involve adding a shader to the state passed into visualise. I have traced the bug to this commit and this PR.

During an internal and offline conversation with @danieldresser, he suggested that the issue is due to Gaffer doing two render passes and sharing one depth buffer, which was checked by adding DepthTestStateComponent(false) to the visualiser state (this fixed the problem, but only when the mesh light was not selected). This comment suggest that there is options to extend the API to to allow visualiser state to also be specified for ColorSpace::Scene.

At IE we would like the option to visualise how mesh lights look, especially when using camera textures.

Steps to reproduce

  1. Add shader to mesh light visualisation, i.e. extend current mesh visualisation.
  2. View mesh light in Gaffer, which does not have visualisation, but only outline.
  3. Do the same thing for Gaffer 1.2 and see that visualisations now exist for mesh lights.
@johnhaddon johnhaddon self-assigned this Aug 22, 2024
@johnhaddon johnhaddon moved this to Up Next in Work in Progress Aug 22, 2024
johnhaddon added a commit to johnhaddon/gaffer that referenced this issue Oct 2, 2024
@johnhaddon
GL Renderer : Fix custom mesh light texture visualisations
4cc3ac4 
These were broken by cfc3857, where we assumed that such visualisations should be rendered with the Display color space. This led to them being rendered after the main Scene color space, meaning that the depth test prevented the texture visualisation from being seen. We now use a heuristic that means such visualisations are rendered first in Scene color space instead.

In theory we could extend the Visualiser API to allow two states to be specified - one for Display space and one for Scene space. But that would require an ABI break, and we want this fix to go into 1.3. We also have so few uses for the visualisation state that it seems like overkill at this point.

Fixes GafferHQ#6002.
@johnhaddon johnhaddon mentioned this issue Oct 2, 2024
Merged
@github-project-automation github-project-automation bot moved this from Up Next to Pending release in Work in Progress Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johnhaddon johnhaddon

Labels
None yet
Projects
Work in Progress
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

GL Renderer : Fix custom mesh light texture visualisations johnhaddon/gaffer
2 participants
@johnhaddon @LinasBeres