Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gaffer 1.2.0.1 Cycles Seg Fault #5147

Closed
abelmilanes opened this issue Feb 15, 2023 · 2 comments
Closed

Gaffer 1.2.0.1 Cycles Seg Fault #5147

abelmilanes opened this issue Feb 15, 2023 · 2 comments

Comments

@abelmilanes
Copy link

abelmilanes commented Feb 15, 2023 •
edited
Loading

Version: Gaffer 1.2.0.1-linux
Linux Distro - Rocky Linux 8.5

Description

Getting a Segmentation Fault when rendering with Cycles.
Attached scene works fine in version 1.1.8-linux-python3

Note shaders and shader assignments are generated via running a python script that parses the USD Materials to generate the nodes.

Steps to reproduce

Open attached project in version 1.2.0.1-linux
Launch interactive render
Gaffer crashes with "Segmentation fault (core dumped)" message

Scene renders fine in version 1.1.8-linux-python3
cycles_chair.zip

Thank you.
@johnhaddon
Copy link
Member

Thanks for the bug report and the simple steps to reproduce. It turns out this was introduced in 1.1.9.0. I have a fix - should be able to get it up for review tomorrow...

johnhaddon added a commit to johnhaddon/gaffer that referenced this issue Feb 16, 2023
@johnhaddon
Cycles SocketAlgo : Fix warning format arguments
b4ac6ae 
There was one too many, which caused `boost::format()` to throw, subsequently crashing Gaffer.

I broke this in 8454f37, where I confidently stated that we didn't need to support transform sockets. But the `texture_coordinate` shader does have such a socket, called `ob_tfm`, which is how this problem surfaced. But I'm still not convinced we need to support it; I'm not sure how a user would use `ob_tfm` - maybe it's more of an implementation detail for Blender?

Fixes GafferHQ#5147.
johnhaddon added a commit to johnhaddon/gaffer that referenced this issue Feb 16, 2023
@johnhaddon
Cycles SocketAlgo : Fix warning format arguments
ae3267f 
There was one too many, which caused `boost::format()` to throw, subsequently crashing Gaffer.

I broke this in 8454f37, where I confidently stated that we didn't need to support transform sockets. But the `texture_coordinate` shader does have such a socket, called `ob_tfm`, which is how this problem surfaced. But I'm still not convinced we need to support it; I'm not sure how a user would use `ob_tfm` - maybe it's more of an implementation detail for Blender?

Fixes GafferHQ#5147.
@johnhaddon johnhaddon mentioned this issue Feb 16, 2023
Merged
@johnhaddon
Copy link
Member

Fixed in #5151.

johnhaddon added a commit to johnhaddon/gaffer that referenced this issue Feb 17, 2023
@johnhaddon
Cycles SocketAlgo : Fix warning format arguments
9490048 
There was one too many, which caused `boost::format()` to throw, subsequently crashing Gaffer.

I broke this in 8454f37, where I confidently stated that we didn't need to support transform sockets. But the `texture_coordinate` shader does have such a socket, called `ob_tfm`, which is how this problem surfaced. But I'm still not convinced we need to support it; I'm not sure how a user would use `ob_tfm` - maybe it's more of an implementation detail for Blender?

Fixes GafferHQ#5147.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@johnhaddon @abelmilanes