Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Code Review] 누찬 code review #16

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
6ddda4e
first commit
seungwon7934 Oct 30, 2024
b197a47
first commit
seungwon7934 Oct 30, 2024
4fbc039
[feat] 5주차 과제: 엔티티 작성 및 연관관계 구현
seungwon7934 Oct 30, 2024
088a8a3
[feat] 6주차 JPA 활용 QueryDSL 실습 코드
seungwon7934 Nov 9, 2024
222b5bf
누찬/이승원 7주차 미션 제출
seungwon7934 Nov 20, 2024
78a1cea
[feat] #4 Springboot 8주차 워크북 내용 수행 - 회원가입 API 구현 및 User Controller, S…
seungwon7934 Nov 20, 2024
9e3c756
[feat] #4 특정 지역에 가게 추가하기 API 구현 및 필요 클래스 작성
seungwon7934 Nov 20, 2024
fa21563
[feat] #4 가게에 리뷰 추가하기 API 구현 및 필요 클래스 작성
seungwon7934 Nov 20, 2024
093c4a0
[feat] #4 가게에 미션 추가하기 API 구현 및 필요 클래스 작성
seungwon7934 Nov 20, 2024
5a4cc3f
[feat] #4 가게의 미션을 도전중인 미션에 추가하는 API 구현 및 필요 클래스 작성
seungwon7934 Nov 20, 2024
a9b6a11
[refactor] #9 디렉토리 구조 변경 및 실행시 DB 조회 코드 주석 처리
seungwon7934 Nov 27, 2024
7796026
[feat] #9 내가 작성한 리뷰 목록 API 구현
seungwon7934 Nov 28, 2024
5553880
[feat] #9 특정 가게의 미션 목록 조회 기능 구현
seungwon7934 Nov 28, 2024
add90b0
[feat] #9 내가 진행중인 미션 목록 기능 구현
seungwon7934 Nov 28, 2024
49e474e
[feat] #9 진행중인 미션 진행 완료로 바꾸기 기능 구현
seungwon7934 Nov 28, 2024
dd2141d
[fix] main - week9 브랜치 통합을 위한 에러 수정
seungwon7934 Dec 8, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 37 additions & 5 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,6 +1,38 @@
*.mp4
*.avi
*.mp3
*.wav
HELP.md
.gradle
build/
!gradle/wrapper/gradle-wrapper.jar
!**/src/main/**/build/
!**/src/test/**/build/

*.DS_Store
### STS ###
.apt_generated
.classpath
.factorypath
.project
.settings
.springBeans
.sts4-cache
bin/
!**/src/main/**/bin/
!**/src/test/**/bin/

### IntelliJ IDEA ###
.idea
*.iws
*.iml
*.ipr
out/
*.yml
!**/src/main/**/out/
!**/src/test/**/out/

### NetBeans ###
/nbproject/private/
/nbbuild/
/dist/
/nbdist/
/.nb-gradle/

### VS Code ###
.vscode/
26 changes: 26 additions & 0 deletions .idea/compiler.xml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.idea는 .gitignore 처리를 해야합니다.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 8 additions & 0 deletions .idea/misc.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions .idea/vcs.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

62 changes: 62 additions & 0 deletions .idea/workspace.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

82 changes: 82 additions & 0 deletions build.gradle
Original file line number Diff line number Diff line change
@@ -0,0 +1,82 @@
plugins {
id 'java'
id 'org.springframework.boot' version '3.3.4'
id 'io.spring.dependency-management' version '1.1.6'
id "com.ewerk.gradle.plugins.querydsl" version "1.0.10" // QueryDSL 플러그인 추가
}

group = 'umc'
version = '0.0.1-SNAPSHOT'

java {
toolchain {
languageVersion = JavaLanguageVersion.of(17)
}
}

configurations {
compileOnly {
extendsFrom annotationProcessor
}
}

repositories {
mavenCentral()
}

dependencies {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

개인적인 선호이지만, 의존성에 대해 어떤 의존성인지 작성해서 관리하는 것을 선호합니다.

implementation 'org.springframework.boot:spring-boot-starter-data-jpa'
implementation 'org.springframework.boot:spring-boot-starter-web'
implementation 'org.springframework.boot:spring-boot-starter-validation'
compileOnly 'org.projectlombok:lombok'
runtimeOnly 'com.mysql:mysql-connector-j'
annotationProcessor 'org.projectlombok:lombok'

testImplementation 'org.springframework.boot:spring-boot-starter-test'
testRuntimeOnly 'org.junit.platform:junit-platform-launcher'

// queryDSL
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QueryDSL 사용은 워크북에서 강제로 시킨거겠죠?

implementation 'com.querydsl:querydsl-jpa:5.0.0:jakarta'
annotationProcessor "com.querydsl:querydsl-apt:5.0.0:jakarta"
annotationProcessor "jakarta.annotation:jakarta.annotation-api"
annotationProcessor "jakarta.persistence:jakarta.persistence-api"

// 추가된 OpenAPI 라이브러리
implementation 'org.springdoc:springdoc-openapi-starter-webmvc-ui:2.1.0'

}

tasks.named('test') {
useJUnitPlatform()
}

tasks.named('compileQuerydsl') {
options.annotationProcessorPath = configurations.annotationProcessor
}

def generated = file("src/main/generated") // 경로를 file()로 명확히 지정

querydsl {
jpa = true
querydslSourcesDir = generated
}

sourceSets {
main {
java {
srcDirs += ['src/main/java', 'src/main/resources', generated]
}
}
}


compileQuerydsl{
options.annotationProcessorPath = configurations.querydsl
}

configurations {
compileOnly {
extendsFrom annotationProcessor
}
querydsl.extendsFrom compileClasspath
}
Binary file added gradle/wrapper/gradle-wrapper.jar
Binary file not shown.
7 changes: 7 additions & 0 deletions gradle/wrapper/gradle-wrapper.properties
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-8.10.2-bin.zip
networkTimeout=10000
validateDistributionUrl=true
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
Loading