This repository has been archived by the owner on May 24, 2024. It is now read-only.
Unify build script #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why does TT even have ++ as a dependency? |
|
Because it uses it in code ( |
bombcar
reviewed
Dec 12, 2021
addon.gradle
Outdated
| @@ -5,7 +5,7 @@ sourceSets.main { | |||
| task initAVRcore(type: Exec) { | |||
| description = "Updates (and inits) git submodules" | |||
| group = "Build Setup" | |||
| commandLine("cmd", "git", "--git-dir=\"" + projectDir.toString() + "/.git\"", "submodule", "update", "--init", "--recursive", "--remote") | |||
| commandLine 'git', '--git-dir="' + projectDir.toString() + '\\.git"', 'submodule', 'update', '--init', '--recursive', '--remote' | |||
There was a problem hiding this comment.
This seems ... suspect. Is there no better way to call git than shelling out with a patched together cmdline?
There was a problem hiding this comment.
I hope to find a way. Jitpack won't accept it. Any ideas?
added 4 commits
December 17, 2021 18:08
# Conflicts: # build.gradle.kts # real.gradle.properties
Dream-Master
approved these changes
Dec 18, 2021
|
since avr code is merge lets try |
basdxz
added a commit
to Technus/TecTech
that referenced
this pull request
Dec 24, 2021
GTNewHorizons/TecTech/pull/19 Update buildscript Unify build script
matt-159
pushed a commit
to GTMEGA/TecTech
that referenced
this pull request
Jul 23, 2022
GTNewHorizons/TecTech/pull/19 Update buildscript Unify build script (cherry picked from commit 062fb04)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Waiting on GT++ unification to be merged, but it is ready for review already!