Added the ability to filter outputs to ME Output Bus and Hatch #3828
+271
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FourIsTheNumber
added
the
enhancement
|
@Diamantino-Op Could you run |
|
Ok, done |
serenibyss
reviewed
Jan 21, 2025
src/main/java/gregtech/common/tileentities/machines/MTEHatchOutputBusME.java
Outdated
Show resolved
Hide resolved
src/main/java/gregtech/common/tileentities/machines/MTEHatchOutputME.java
Outdated
Show resolved
Hide resolved
| @@ -207,6 +315,9 @@ public void onFacingChange() { | |||
| @Override | |||
| public boolean onRightclick(IGregTechTileEntity aBaseMetaTileEntity, EntityPlayer aPlayer) { | |||
| GTUIInfos.openGTTileEntityUI(aBaseMetaTileEntity, aPlayer); | |||
|
|
|||
| lastClickedPlayer = aPlayer; | |||
There was a problem hiding this comment.
I don't like this way of caching the player reference for locking, as it could lead to missed calls (especially across server/client) and potentially leaking world reference
There was a problem hiding this comment.
Yeah, i should find a better way to get the player, this was the first thing that came to my mind.
Comment on lines
+2381
to
+2383
| if (((MTEHatchOutputBusME) tHatch).isLocked()) { | ||
| return false; | ||
| } |
There was a problem hiding this comment.
This change will require voiding mode to be extensively tested, as this function greatly changes void protection calculation
There was a problem hiding this comment.
i tested with multi hatch, but did not test what happens when it overflows or try to craft when the hatch is full
…tputBusME.java Co-authored-by: Maya <[email protected]>
…tputME.java Co-authored-by: Maya <[email protected]>
Co-authored-by: Maya <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.