support null typing and no required value on userid, check for null u…

…serid in donation server action

server/actions/donation.ts

@@ -4,6 +4,7 @@ import Stripe from "stripe";
 import Mongo, { stripeConstructor } from "server/index";
 import Donation from "server/models/donation";
 import Nonprofit from "server/models/nonprofit";
+import User from "server/models/user";
 import errors from "utils/errors";
 import { Donation as DonationType } from "utils/types";
 
@@ -17,12 +18,16 @@ export async function logDonation({
   await Mongo();
 
   const nonprofit = await Nonprofit.findOne({ _id: nonprofitId });
-  const user = await Donation.findOne({ _id: userId }); // TODO: Don't allow front end to pass null resulting userId
+  const user = await User.findOne({ _id: userId }); // TODO: Don't allow front end to pass null resulting userId
 
   if (!nonprofit) {
     throw new Error(errors.nonprofit.INVALID_ID);
   }
 
+  if (!user) {
+    throw new Error(errors.user.INVALID_ID);
+  }
+
   const donation = await Donation.create({
     name,
     email,

server/models/donation.js

@@ -22,8 +22,7 @@ const donationSchema = new Schema({
   },
   userId: {
     type: String,
-    ref: "User",
-    required: true
+    ref: "User"
   },
   timestamp: {
     type: Date,

utils/errors.ts

@@ -15,5 +15,8 @@ export default {
   },
   event: {
     INVALID_ID: "An event with the provided ID does not exist in our database."
+  },
+  user: {
+    INVALID_ID: "A user with the provided ID does not exist in our database."
   }
 };

utils/types.ts

@@ -34,7 +34,7 @@ export interface Donation {
   email: string;
   amount: number;
   nonprofitId: string;
-  userId: string;
+  userId: string | null;
   timestamp: Date;
 }