Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Won't recognize icon if more than one whitespace character after opening tag #2

Closed
meirroth opened this issue May 18, 2021 · 2 comments

Comments

@meirroth
Copy link
Contributor

The autogen wont recognize the icon if there is more than one whitespace character after the opening tag,
Here are two examples:
1.
<famore than one whitespaceicon="fas-info-circle" />
2.

<fa
  icon="fas-info-circle"
  ....
/>

Looking through the source code I see there is a regex on line 23:
/(?<=<fa\sicon="+).*?(?=")/g
adding a plus quantifier after the \s meta escape, solves this issue.
See before and after on regex101.com

@GTANAdam
Copy link
Owner

Greetings, thank you for bringing attention to this, could you please submit a pull request?

@meirroth
Copy link
Contributor Author

Sure!

GTANAdam added a commit that referenced this issue May 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants