Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added print statements to test results #335

Merged
merged 3 commits into from
Apr 18, 2023

Conversation

Lucrezia-Cester
Copy link
Contributor

@Lucrezia-Cester Lucrezia-Cester commented Apr 14, 2023

I have added print statements to the test functions within the test scripts that test for the entire function.

This should ensure that the physicists can check the results of the test functions in the terminal if they run pytest -v -s tests/
.

@tomaroberts, @heyhaleema, could you take a look at this PR and the respective issue?

@elizaGSTT can you let me know if this resolves the conformity issue?

I have added print statements to the test functions within the test scripts that test for the entire function
@Lucrezia-Cester Lucrezia-Cester linked an issue Apr 14, 2023 that may be closed by this pull request
@Lucrezia-Cester Lucrezia-Cester mentioned this pull request Apr 14, 2023
@github-actions
Copy link

github-actions bot commented Apr 14, 2023

Coverage

Coverage Report
FileStmtsMissCoverMissing
hazenlib
   HazenTask.py26388%32–34
   __init__.py1514173%141, 145, 155, 160, 197, 204–209, 220, 223–230, 250–252, 270–272, 291–293, 302, 307, 313, 363, 374, 380–386, 400–401, 405
   exceptions.py21481%17–21
   relaxometry.py3179072%238–256, 631, 690–692, 746, 794–816, 834–849, 1174–1177, 1186–1189, 1201–1214, 1217–1222, 1233–1263
   shapes.py20955%13, 16, 24–29, 32
   tools.py84890%43–50, 92, 101, 117
hazenlib/tasks
   acr_geometric_accuracy.py1455562%38–72, 176–192, 206–230
   acr_ghosting.py1164264%33–53, 91–93, 123–125, 161–194
   acr_slice_position.py1545366%53–74, 152, 213–258
   acr_slice_thickness.py1536359%40–60, 186–241
   acr_snr.py1375858%34–71, 96, 165–175, 208–221, 254–267
   acr_spatial_resolution.py2427270%66–86, 165, 208, 221–230, 319–374
   acr_uniformity.py893264%34–54, 121–138
   ghosting.py1505166%18–32, 47, 109–110, 114, 124–125, 151–153, 170–172, 218–256
   relaxometry.py7271%10–11
   slice_position.py1182281%31, 40–41, 103–104, 130, 210, 217–234
   slice_width.py3595286%34–37, 107, 166–186, 451, 456–457, 463, 468, 530–531, 780–821
   snr.py1636660%62–67, 161–179, 194–203, 221–231, 258–268, 273–283, 314–327, 332–340, 369–382
   snr_map.py106199%294
   spatial_resolution.py2474482%36–39, 62, 147, 206, 332–368
   uniformity.py781976%42–45, 91–92, 99, 133–147
TOTAL289978773% 

Tests Skipped Failures Errors Time
219 0 💤 0 ❌ 0 🔥 2m 37s ⏱️

Copy link
Collaborator

@YassineAzma YassineAzma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this, Lucrezia. Could you please also add a print statement for the slice 5 function in ACR Geometric Accuracy.

@Lucrezia-Cester
Copy link
Contributor Author

Hi @YassineAzma, I have added this.

Let me know if it can be merged now.

@Lucrezia-Cester Lucrezia-Cester changed the base branch from main to release/1.2 April 14, 2023 09:02
@Lucrezia-Cester
Copy link
Contributor Author

Lucrezia-Cester commented Apr 18, 2023

Hi @YassineAzma, could you please approve this PR? I have added the changes you requested..

@YassineAzma
Copy link
Collaborator

Sorry for the delay.

@Lucrezia-Cester Lucrezia-Cester merged commit b33a80d into release/1.2 Apr 18, 2023
@Lucrezia-Cester Lucrezia-Cester deleted the 334-qms-conformity branch April 18, 2023 08:26
@Lucrezia-Cester Lucrezia-Cester restored the 334-qms-conformity branch April 18, 2023 13:42
@tomaroberts tomaroberts deleted the 334-qms-conformity branch August 23, 2023 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QMS Conformity
2 participants