Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds .readthedocs.yaml to fix RTD build #288

Merged
merged 4 commits into from
Dec 19, 2022
Merged

Adds .readthedocs.yaml to fix RTD build #288

merged 4 commits into from
Dec 19, 2022

Conversation

heyhaleema
Copy link
Collaborator

This PR adds a ReadTheDocs (RTD) configuration file (see docs here and closed issue here) since the build is currently failing due to outdated Python version being used in virtual environment (see error message here).

@heyhaleema heyhaleema added the broken Existing functionality is not working label Dec 15, 2022
@heyhaleema heyhaleema self-assigned this Dec 15, 2022
@github-actions
Copy link

github-actions bot commented Dec 15, 2022

@heyhaleema heyhaleema requested a review from hshuaib90 December 16, 2022 12:32
@hshuaib90
Copy link
Collaborator

This branch is still failing to build on RTD
image

@heyhaleema
Copy link
Collaborator Author

@hshuaib90 It looks like that build checked out main rather than add-rtd-yaml, so I did some testing on fix-readthedocs and it now works again there (see build here). I think the main issue is that if you use the RTD configuration file, the default sphinx version is (assumedly) the latest, i.e. 5.3.0.

We used this configuration file in order to be able to install a later version of scipy with an updated Python version, but sphinx 5.3.0 doesn't seem to support sphinxcontrib-bibtex (see build here). The fix was to include/uncomment the option to install requirements.txt so that we could pin the Sphinx version before the default was used/rest of the build continues.

@hshuaib90
Copy link
Collaborator

I'm slightly confused. Why is the build on RTD not referencing this branch but the fix_readthedocs branch instead? How do we know this branch will build when it merges to main?

@heyhaleema
Copy link
Collaborator Author

heyhaleema commented Dec 16, 2022

@hshuaib90 I think it's because we currently* need to explicitly activate the branches/versions we want RTD to trigger a build on:

image

We would ideally then activate the relevant development branch prior to merging with main (or release branch?) to reconfirm the RTD build hasn't broken, so if you activate add-rtd-yaml, we can see if it works there, too. The latest version hasn't yet passed successfully because of that issue with the newerscipy version which is why it's only passed on fix-readthedocs since that branch was using an older version.

* It looks like we can automate this - see here.

@hshuaib90
Copy link
Collaborator

Yes you are right! Sorry, just built it and it works.

@heyhaleema heyhaleema merged commit e4f4e32 into main Dec 19, 2022
@heyhaleema heyhaleema deleted the add-rtd-yaml branch December 19, 2022 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
broken Existing functionality is not working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants