Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated LSF function #191

Merged
merged 3 commits into from
Dec 22, 2021
Merged

Updated LSF function #191

merged 3 commits into from
Dec 22, 2021

Conversation

Lucrezia-Cester
Copy link
Contributor

No description provided.

@github-actions
Copy link

github-actions bot commented Dec 22, 2021 •
edited
Loading

Coverage

Coverage Report
FileStmtsMissCoverMissing
hazenlib
   init.py1296252%135, 139, 149, 154, 190–193, 198–203, 214, 217–224, 244–246, 264–266, 285–287, 296, 300–303, 307, 313–362
   ghosting.py1565068%24, 89–90, 94, 104–105, 132–133, 142–143, 198–226, 233–251, 255
   relaxometry.py3179072%238–256, 630, 689–691, 745, 793–815, 833–848, 1173–1176, 1185–1188, 1200–1213, 1216–1221, 1233–1263
   slice_position.py1102082%73–74, 99, 183, 190–203, 211, 219–220, 231
   slice_width.py2904584%24, 27, 31, 35–40, 106, 277, 282–283, 289, 294, 357–358, 593–632, 668–671, 674–677
   snr.py1654871%42–47, 75, 209–219, 262–266, 304–315, 321–329, 357–368, 392, 400–402, 405
   spatial_resolution.py2939966%44–102, 116, 208, 248–255, 283, 414–447, 474–491
   tools.py75692%43–50, 89
   uniformity.py792272%69–70, 77, 111–123, 135–137, 140, 144–147, 155
TOTAL165044273% 

Tests Skipped Failures Errors Time
170 0 💤 0 ❌ 0 🔥 142.209s ⏱️

tomaroberts
tomaroberts requested changes Dec 22, 2021
View reviewed changes
Copy link
Collaborator

@tomaroberts tomaroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of minor comments.

Would you mind adding a description to the initial PR post as well for future reference? And link any issues.

tests/test_spatial_resolution.py Outdated
MTF_PE = 0.4923415061063675
bisecting_normal = (281, 245, 319, 239)
print('this is phil',hazen_spatial_resolution.calculate_mtf(dicom))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to leave this in?

tests/test_spatial_resolution.py Outdated
@@ -170,3 +174,4 @@ class TestEastKentResolution(TestSpatialResolution):
MTF_FE = 0.9924200730536655
MTF_PE = 0.9924200730536658
bisecting_normal = (137, 126, 155, 122)
print('this is east',hazen_spatial_resolution.calculate_mtf(dicom))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And this one?

@tomaroberts tomaroberts changed the title updated lsf fun Updates LSF function Dec 22, 2021
@tomaroberts tomaroberts changed the title Updates LSF function Updated LSF function Dec 22, 2021
@Lucrezia-Cester
Copy link
Contributor Author

@tomaroberts I changed according to the comments.

@tomaroberts tomaroberts added this to the 0.5.2 milestone Dec 22, 2021
@tomaroberts tomaroberts merged commit 6e23b07 into release/0.5.2 Dec 22, 2021
@tomaroberts tomaroberts deleted the LSF_python9 branch December 22, 2021 12:00
This was referenced Dec 22, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomaroberts tomaroberts tomaroberts requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.5.2
Development

Successfully merging this pull request may close these issues.
2 participants
@Lucrezia-Cester @tomaroberts