Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(systemvolume): remove requestSinks #1890

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor(systemvolume): remove requestSinks #1890

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions installed-tests/suites/plugins/testSystemvolumePlugin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ describe('The systemvolume plugin', function () {
},
});
testRig.setPaired(true);
testRig.setConnected(true);

remoteDevice = testRig.remoteDevice;
remoteDevice.handlePacket = handlePacket.bind(remoteDevice);
Expand All @@ -70,14 +71,6 @@ describe('The systemvolume plugin', function () {
expect(localPlugin).toBeDefined();
});

it('sends streams when connected', function () {
spyOn(localPlugin, '_sendSinkList');

testRig.setConnected(true);

expect(localPlugin._sendSinkList).toHaveBeenCalled();
});

it('sends a list of streams when requested', async function () {
spyOn(remoteDevice, 'handlePacket').and.callThrough();

Expand Down
6 changes: 0 additions & 6 deletions src/service/plugins/systemvolume.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,12 +73,6 @@ const SystemVolumePlugin = GObject.registerClass({
}
}

connected() {
super.connected();

this._sendSinkList();
}

/**
* Handle a request to change an output
*
Expand Down