Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise remote input timeout to 300 seconds #1844

Merged
merged 1 commit into from
Jul 20, 2024

Conversation

ferdnyc
Copy link
Member

@ferdnyc ferdnyc commented Jul 20, 2024

The first input event on reconnection is currently being lost, this should make reconnections much less frequent. See #1836.

I don't want to mark that issue as fixed with this, since it's really just a workaround until we can figure out why input events are being lost. See my comment on the issue for more detail(/confused ramblings).

The first input event on reconnection is currently being lost, this
should make reconnections much less frequent. See GSConnect#1836.
@ferdnyc ferdnyc enabled auto-merge (rebase) July 20, 2024 14:16
@andyholmes
Copy link
Collaborator

If the Closed signal works properly, you can probably remove the timeout altogether. I don't recall why I did that, it was quite some time ago now.

@ferdnyc ferdnyc merged commit fc3030b into GSConnect:main Jul 20, 2024
2 checks passed
@ferdnyc ferdnyc deleted the remote-input-timeout branch July 20, 2024 14:58
@ferdnyc
Copy link
Member Author

ferdnyc commented Jul 20, 2024

@andyholmes I think we'd want to have some kind of timeout, because AFAICT Mutter doesn't have one, and is happy to leave us connected indefinitely. And there doesn't seem to be any message sent from KDE Connect that would signal the end of an input session (when the user exits the "Presentation remote" or "Remote input" interfaces, for example).

So without a timeout it seems like GSConnect would just sit around being connected... forever. Which I'm concerned could interfere with powersave and the like. (Though it's probably the other way around, entering powersave would probably forcibly disconnect us.)

@ferdnyc ferdnyc added this to the v58 milestone Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants