Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Black config, AppStream template #1812

Merged
merged 6 commits into from
Jun 12, 2024

Conversation

ferdnyc
Copy link
Member

@ferdnyc ferdnyc commented May 24, 2024

Python: Configure Black for Python 3.8-3.12

Our previous Black target-version, py36, reached its end-of-life date some time ago. In fact, py37 is already unsupported, as well.

In addition, according to the Black docs, we should configure for all supported versions, not simply a minimum.

So, set the targeted Pythons to py38 through py312 inclusive.

AppStream: Update SPDX license, developer tag

  • The license for the AppStream metadata itself is CC0-1.0, says so right in the metadata_license tag. Correct the REUSE header to match.
  • The developer_name tag is deprecated, replaced by the developer tag which contains an id attribute and a name child. Adopt the new hotness.

ferdnyc added 3 commits May 24, 2024 13:49
Our previous Black `target-version`, `py36`, reached its end-of-life
date some time ago. In fact, `py37` is already unsupported, as well.

In addition, according to the Black docs, we should configure for
_all_ supported versions, not simply a minimum.[1]

So, set the targeted Pythons to `py38` through `py312` inclusive.

[1]: https://black.readthedocs.io/en/stable/usage_and_configuration/the_basics.html#command-line-options
* The license for the AppStream metadata itself is `CC0-1.0`, says so
  right in the `metadata_license` tag. Correct the REUSE header to
  match.
* The `developer_name` tag is deprecated[1], replaced by the
  `developer` tag which contains `name` and `id` children. Adopt
  the new hotness.

[1]: https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-developer_name
@ferdnyc ferdnyc changed the title Python: Configure Black for Python 3.8-3.12 Update Black config, AppStream template May 27, 2024
@ferdnyc ferdnyc marked this pull request as draft May 27, 2024 16:49
@ferdnyc
Copy link
Member Author

ferdnyc commented May 27, 2024

I got the new developer tag format slightly wrong, will update this.

@ferdnyc ferdnyc marked this pull request as ready for review May 27, 2024 16:59
Copy link
Collaborator

@andyholmes andyholmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ferdnyc ferdnyc merged commit b594c6f into GSConnect:main Jun 12, 2024
3 checks passed
@ferdnyc ferdnyc deleted the raise-python-level branch June 12, 2024 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants