Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(housekeeping) Shorten display labels in CI jobs #1811

Merged
merged 2 commits into from
Jun 12, 2024

Conversation

ferdnyc
Copy link
Member

@ferdnyc ferdnyc commented May 22, 2024

GitHub currently labels each of the "Checks" workflow jobs on a PR in the format: ${{ workflow.name }} / ${{ job.id }} (${ trigger }}), which leaves us with long labels like:

  • Label merge conflicts / conflicts (pull_request_target)
  • REUSE Verification / lint (pull_request)

This will (slightly) trim those down to:

  • Merge conflicts / label (pull_request_target)
  • REUSE / verify (pull_request)

GitHub currently labels each of the "Checks" workflow jobs on a PR
in the format: `${{ workflow.name }} / ${{ job.id }} (${ trigger }})`,
which leaves us with long labels like:
* `Label merge conflicts / conflicts (pull_request_target)`
* `REUSE Verification / lint (pull_request)`

This will (slightly) trim those down to:
* `Merge conflicts / label (pull_request_target)`
* `REUSE / verify (pull_request)`
@ferdnyc
Copy link
Member Author

ferdnyc commented May 22, 2024

. o O (Hmm. I hope label isn't a keyword. ...Ehhh, it'llllll probably be fine.)

@ferdnyc
Copy link
Member Author

ferdnyc commented May 27, 2024

Hmm. I can't Approve my own changes, so the choice is between force-overriding the branch protections, vs. waiting for someone else to take a peek.

@ferdnyc
Copy link
Member Author

ferdnyc commented Jun 1, 2024

Looks like, when this is merged, the list of checks required by the main branch will need to be updated accordingly. (At https://github.com/GSConnect/gnome-shell-extension-gsconnect/settings/branches.) But AFAICT that can't be done until either immediately before or immediately after the merge.

@ferdnyc ferdnyc merged commit c82f30d into GSConnect:main Jun 12, 2024
3 checks passed
@ferdnyc ferdnyc deleted the shorter-ci-labels branch June 12, 2024 04:25
@ferdnyc
Copy link
Member Author

ferdnyc commented Jun 12, 2024

Merged, and protection rules updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants