Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: Add received file to recent file list #1810

Conversation

ketanbaitule
Copy link
Contributor

What does this PR do?

Whenever we send files from mobile to desktop, It adds the file into recent menu

Test

  1. Send a file from mobile
  2. After successful transmission of file, check Recent file.

Related PRs and Issues

Test Video

Final-2024-05-22.15-09-41.mp4

Copy link
Member

@ferdnyc ferdnyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @ketanbaitule, be nice to tick that one off the to-do list.

One minor suggestion, but this looks good. Makes sense to me.

src/service/plugins/share.js Outdated Show resolved Hide resolved
@ferdnyc ferdnyc enabled auto-merge (rebase) May 30, 2024 01:32
@ferdnyc
Copy link
Member

ferdnyc commented May 30, 2024

Tested, and this works well. Setting to merge. Thanks, @ketanbaitule !

@ferdnyc ferdnyc merged commit 4ea5d4e into GSConnect:main May 30, 2024
3 checks passed
@ferdnyc ferdnyc added this to the v58 milestone Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add received files to Recent Files list
2 participants