Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert PR 1663 update check data controller dependency injection #1677

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

gchi25
Copy link
Collaborator

@gchi25 gchi25 commented Aug 15, 2024

PR Summary

This work reverts PR 1663.

Related Github Issue

Detailed Testing steps

To test in local development site or in dev site.

  • Pull changes locally
  • Make local development site up at http://localhost
  • In local, $ docker restart cms
  • In local, $ bin/drush cr
  • Navigate to benefit-finder/content/report
  • Verify it shows 3 sections of criteria, benefit, and life event form
  • Open criteria "Applicant date of birth"
  • Navigate to admin/content?combine=&type=bears_criteria&status=All&langcode=All
  • Go to criteria "Applicant date of birth" edit page
  • Verify criteria report data is correct
  • Open benefit "COVID-19 funeral assistance
  • Navigate to admin/content?combine=&type=bears_benefit&status=All&langcode=All
  • Go to benefit "COVID-19 funeral assistance" edit page
  • Verify benefit report data is correct
  • Open life event form "Benefit finder: death of a loved one"
  • Navigate to admin/content?combine=&type=bears_life_event_form&status=All&langcode=All
  • Go to life event form "Benefit finder: death of a loved one" edit page
  • Verify life event form report data is correct

@gchi25 gchi25 self-assigned this Aug 15, 2024
@gchi25 gchi25 marked this pull request as draft August 15, 2024 12:10
@scottqueen-bixal scottqueen-bixal removed the request for review from nehemiah-abuga August 15, 2024 14:09
@gchi25 gchi25 requested a review from nehemiah-abuga August 15, 2024 14:10
@gchi25 gchi25 marked this pull request as ready for review August 15, 2024 14:10
@scottqueen-bixal scottqueen-bixal merged commit ce98165 into dev Aug 15, 2024
7 checks passed
@scottqueen-bixal scottqueen-bixal deleted the revert-pr-1663 branch August 15, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update check data controller with dependency injection
2 participants