Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update button styles, and update variant types in application components #1455

Merged
merged 40 commits into from
Aug 15, 2024

Conversation

scottqueen-bixal
Copy link
Collaborator

@scottqueen-bixal scottqueen-bixal commented Jun 17, 2024

PR Summary

This works to update our buttons for unstyled, secondary, default, and outline, it also updates the respective type to the associated location on the application as recommended by USAGov.

Related Github Issue

Detailed Testing steps

  • pull changes locally
  • cd benefit-finder
  • npm install
Screenshot 2024-06-17 at 5 17 57 PM
  • tab to focus, confirm variant styles are as follows
Screenshot 2024-06-17 at 5 22 56 PM Screenshot 2024-06-17 at 5 23 15 PM Screenshot 2024-06-17 at 5 23 23 PM Screenshot 2024-06-17 at 5 23 44 PM
  • npm run start
  • ensure the following variant assignments have taken place in the application
  • start button is secondary
Screenshot 2024-06-17 at 5 04 10 PM - [ ] grouped buttons in navigation of form steps are `outline` for `back`, and `secondary` for `continue` Screenshot 2024-06-17 at 5 04 25 PM - [ ] modal buttons are `secondary` Screenshot 2024-06-17 at 5 05 36 PM - [ ] results view toggle to `not eligible` lists are `secondary` Screenshot 2024-06-17 at 5 06 08 PM - [ ] accordion links as buttons inside the accordion content are `secondary` Screenshot 2024-06-17 at 5 06 28 PM - [ ] `share` and `email` buttons are replaced with "trigger" anchor elements Screenshot 2024-06-17 at 5 06 45 PM

@scottqueen-bixal scottqueen-bixal requested a review from gchi25 June 17, 2024 21:30
@scottqueen-bixal scottqueen-bixal self-assigned this Jun 17, 2024
Xavier Metichecchia and others added 28 commits June 20, 2024 10:07
@scottqueen-bixal scottqueen-bixal force-pushed the 1446-updated-button-styles branch from 278008d to d256553 Compare June 20, 2024 14:10
…/px-benefit-finder into 1446-updated-button-styles
@scottqueen-bixal scottqueen-bixal marked this pull request as draft June 25, 2024 13:22
@gchi25
Copy link
Collaborator

gchi25 commented Jun 27, 2024

Need to update the testing instruction.
image

Copy link
Collaborator

@gchi25 gchi25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. Worked as expected.

@scottqueen-bixal scottqueen-bixal merged commit 7ea35fd into dev Aug 15, 2024
13 checks passed
@scottqueen-bixal scottqueen-bixal deleted the 1446-updated-button-styles branch August 15, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DESIGN | Update Button styles
2 participants