1391 db backup issues #1418
Merged
1391 db backup issues #1418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XavierMetichecchia
requested review from
scottqueen-bixal and
casey-rapnicki-bixal
casey-rapnicki-bixal
pushed a commit
that referenced
this pull request
Jun 12, 2024
1391 db backup issues
casey-rapnicki-bixal
pushed a commit
that referenced
this pull request
Jun 12, 2024
1391 db backup issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This PR adds some code to the database upload to s3 script the adds some verification steps to the temporarily created aws s3 credentials used during the upload.
Related Github Issue
Detailed Testing steps
Make sure the database backups pipelines in dev and main work reliably with this new credential checker.